Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(signature): Double-check signature logic using third-party tools. #152

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

ryanschneider
Copy link
Contributor

πŸ“ Summary

Adds two more unit tests for flashbots.ParseSignature using two signatures generated via MetaMask and cast.

β›± Motivation and Context

I realized that the existing TestParseSignature test uses the crypto package to generate the signatures, and since this is the same package we use internally to verify the signatures it was possible that we had a bug in both our uses for generation and validation of the package. So as an extra sanity check I generated two additional signatures using MetaMask and cast to confirm that our signature verification code works across multiple signature implementations.

πŸ“š References

I actually wasn't aware of this nice extra feature of etherscan where signatures can be published that also offers a nice UI for prompting your wallet to generate a signature: https://etherscan.io/verifiedSignatures#


βœ… I have run these commands

  • make lint
  • make test
  • go mod tidy

Copy link
Collaborator

@metachris metachris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@metachris metachris merged commit 977b757 into main Aug 16, 2024
2 checks passed
@metachris metachris deleted the more-signature-tests branch August 16, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants